Use std::list instead of std::deque for all buffers/queues in streams #3260
+16
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API implementation objects. A very common use case is to create one or more stream API objects per request. These streams currently have a high native memory overhead even when they are empty. Switching to std::list (which doesn't pre-allocate space for items) significantly alleviates this problem. For example, now ReadableStreams tend to have <50% of their original memory footprint.
danlapid
approved these changes
Dec 19, 2024
|
I have a single concern about one of these conversions. We currently iterate through @jasnell thoughts on whether it is feasible/worth it to avoid doing this every time we call |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API implementation objects.
A very common use case is to create one or more stream API objects per request. These streams currently have a high native memory overhead even when they are empty. Switching to std::list (which doesn't pre-allocate space for items) significantly alleviates this problem.
For example, now ReadableStreams tend to have <50% of their original memory footprint.