[o11y] Add traceId to user trace #3209
Draft
+398
−75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be used to better export user tracing spans in a follow-up PR.
jasnell
reviewed
Dec 4, 2024
| @@ -92,6 +92,9 @@ class TraceId final { | |||
| // Replicates W3C Serialization | |||
| kj::String toW3C() const; | |||
|
|
|||
| // Return network order hex representation | |||
| kj::String toNEHex() const; | |||
There was a problem hiding this comment.
Nit: While it's more verbose, I prefer avoiding the abbreviation here. s/toNEHex/toNetworkOrderHex
jasnell
reviewed
Dec 4, 2024
| @@ -609,6 +616,7 @@ class WorkerTracer final: public kj::Refcounted, public BaseTracer { | |||
|
|
|||
| void addLog(kj::Date timestamp, LogLevel logLevel, kj::String message) override; | |||
| void addSpan(CompleteSpan&& span) override; | |||
| void setTraceId(tracing::TraceId traceId); | |||
There was a problem hiding this comment.
Nit: const tracing::TraceId& to prevent the extra copy? I know it's a small class but still. Could also get by with having the trace->traceId = traceId in the impl be a trace->traceId = kj::mv(traceId)
fhanau
force-pushed
the
felix/111524-user-tracing-otel-v1
branch
3 times, most recently
from
598986f to
956a297
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #3180. Also see the corresponding upstream PR.