Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Header Indicating Suspense Cache HIT #787

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Add Header Indicating Suspense Cache HIT #787

wants to merge 4 commits into from

Conversation

james-elicx
Copy link
Contributor

@james-elicx james-elicx commented May 15, 2024 •
edited
Loading

fixes #786

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 15, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: dadbe42

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 15, 2024 •
edited
Loading

🧪 Prereleases are available for testing 🧪

@cloudflare/next-on-pages

You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/next-on-pages/runs/9197161283/npm-package-next-on-pages-787

@cloudflare/eslint-plugin-next-on-pages

You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/next-on-pages/runs/9197161283/npm-package-eslint-plugin-next-on-pages-787

@james-elicx james-elicx force-pushed the james/make-walshy-happy branch 4 times, most recently from 16ee6d4 to c24b3e0 Compare May 15, 2024 17:43
@james-elicx james-elicx marked this pull request as ready for review May 15, 2024 18:31
dario-piotrowicz
dario-piotrowicz approved these changes May 19, 2024
View reviewed changes
Copy link
Member

@dario-piotrowicz dario-piotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a few minor nits, thanks a bunch @james-elicx 😄

pages-e2e/fixtures/app14.0.0/main.fixture Outdated Show resolved Hide resolved
pages-e2e/features/appFetchCache/fetch-cache.test.ts Outdated Show resolved Hide resolved
packages/next-on-pages/templates/_worker.js/utils/cache.ts Outdated Show resolved Hide resolved
@james-elicx james-elicx force-pushed the james/make-walshy-happy branch 2 times, most recently from bade830 to 78c60b8 Compare May 21, 2024 07:16
@dario-piotrowicz
Copy link
Member

@james-elicx could you have a look at the e2e failure? 😅 https://github.com/cloudflare/next-on-pages/actions/runs/9170973019/job/25220047035?pr=787#step:4:679

it does seem legit 😓

@james-elicx
Copy link
Contributor Author

@james-elicx could you have a look at the e2e failure? 😅 cloudflare/next-on-pages/actions/runs/9170973019/job/25220047035?pr=787#step:4:679

it does seem legit 😓

can we delete the e2es? smh

@james-elicx james-elicx marked this pull request as draft May 27, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dario-piotrowicz dario-piotrowicz dario-piotrowicz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[⚡ Feature]: Implement next-suspense-cache header
2 participants
@james-elicx @dario-piotrowicz