Improve handling of self-closing syntax #254
Open
+73
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kornelski
requested review from
jongiddy,
Noah-Kennedy,
orium,
scotchmist,
jasnell and
a team
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In HTML (and XHTML sent as
text/html),<foo />is not closed, and is functionally identical to<foo>. In HTML content/>is a syntax error on non-void elements, and a useless talisman on void elements.Authors used to XML or JSX find it hard to believe, so I've updated the documentation to reiterate this fact.
Additionally, if content is added to an element with the
/>syntax error, the invalid/will be removed to avoid surprising users with<foo/>content</foo>.The library still preserves the
/>syntax in other cases, even when it's useless or invalid, to keep syntax consistent with non-rewritten content (where it wouldn't be changed), and out of caution in case our parser gets out of sync with SVG/MathML namespace.