Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/network #7

Closed
wants to merge 5 commits into from
Closed

Feature/network #7

wants to merge 5 commits into from

Conversation

dev-kimdoyoung
Copy link
Collaborator

@dev-kimdoyoung dev-kimdoyoung commented Dec 10, 2023 •
edited
Loading

suite 및 mock 기반 테스트 케이스 추가

변경 사항 명시

suite_test.go

  • suite 초기 셋팅 구현

server.go

  • ncp server type 에서 interface 임베딩

*_test.go

  • suite 및 mock 기반 테스트 케이스 추가 (테이블을 활용한 테스트 방식 적용)

server.go

  • do를 활용한 api crud 구현

@dev-kimdoyoung dev-kimdoyoung self-assigned this Dec 10, 2023
n-y-kim
n-y-kim reviewed Dec 12, 2023
View reviewed changes
Copy link
Member

@n-y-kim n-y-kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dev-kimdoyoung 도영님, suite가 따로 필요한 이유가 뭔가요?

n-y-kim
n-y-kim reviewed Dec 12, 2023
View reviewed changes
pkg/common/httputil.go
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

httputil.go와 server.go 의 차이가 뭔가요? 필드 값에 token 유무만 다른 것 같은데 httputil은 ncp API 호출용이고 server는 Aviator(kubebuilder) 쪽에서 호출하는용....... ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n-y-kim n-y-kim n-y-kim left review comments

Assignees

@dev-kimdoyoung dev-kimdoyoung

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dev-kimdoyoung @n-y-kim