Adds jupyter-lsp, python-lsp-server, and notebook to 1.0.0 beta (aws#82)

* Adds jupyter-lsp and notebook to test harness * Reinstates test suites * Revert "Release v0.7.0 (aws#75)" This reverts commit 5234f45. * Revert "Revert "Release v0.7.0 (aws#75)"" This reverts commit b8b8d1a. * Adds python-lsp-server test * Adds python-lsp-server to test harness --------- Co-authored-by: Jason Weill <[email protected]>
claytonparnell · Oct 20, 2023 · d48052f · d48052f
1 parent b54d1fc
commit d48052f
Show file tree

Hide file tree

Showing 4 changed files with 27 additions and 2 deletions.
diff --git a/test/test_artifacts/v1/jupyter-lsp.test.Dockerfile b/test/test_artifacts/v1/jupyter-lsp.test.Dockerfile
@@ -0,0 +1,6 @@
+ARG COSMOS_IMAGE
+FROM $COSMOS_IMAGE
+
+ARG MAMBA_DOCKERFILE_ACTIVATE=1
+
+CMD ["python", "-c", "import jupyter_lsp"]
diff --git a/test/test_artifacts/v1/notebook.test.Dockerfile b/test/test_artifacts/v1/notebook.test.Dockerfile
@@ -0,0 +1,6 @@
+ARG COSMOS_IMAGE
+FROM $COSMOS_IMAGE
+
+ARG MAMBA_DOCKERFILE_ACTIVATE=1
+
+CMD ["python", "-c", "import notebook"]
diff --git a/test/test_artifacts/v1/python-lsp-server.test.Dockerfile b/test/test_artifacts/v1/python-lsp-server.test.Dockerfile
@@ -0,0 +1,7 @@
+ARG COSMOS_IMAGE
+FROM $COSMOS_IMAGE
+
+ARG MAMBA_DOCKERFILE_ACTIVATE=1
+
+# "Confirm that installation succeeded" by running this - https://github.com/python-lsp/python-lsp-server#installation
+CMD ["pylsp", "--help"]
diff --git a/test/test_dockerfile_based_harness.py b/test/test_dockerfile_based_harness.py
@@ -27,7 +27,10 @@
     ("sm-python-sdk.test.Dockerfile", ['sagemaker-python-sdk']),
     ("pytorch.examples.Dockerfile", ['pytorch']),
     ("tensorflow.examples.Dockerfile", ['tensorflow']),
-    ("jupyter-ai.test.Dockerfile", ['jupyter-ai'])])
+    ("jupyter-ai.test.Dockerfile", ['jupyter-ai']),
+    ("jupyter-lsp.test.Dockerfile", ['jupyter-lsp']),
+    ("jupyter-lsp-server.test.Dockerfile", ['jupyter-lsp-server']),
+    ("notebook.test.Dockerfile", ['notebook'])])
 def test_dockerfiles_for_cpu(dockerfile_path: str, required_packages: List[str],
                              local_image_version: str, use_gpu: bool):
     _validate_docker_images(dockerfile_path, required_packages, local_image_version, use_gpu, 'cpu')
@@ -45,7 +48,10 @@ def test_dockerfiles_for_cpu(dockerfile_path: str, required_packages: List[str],
     ("sm-python-sdk.test.Dockerfile", ['sagemaker-python-sdk']),
     ("pytorch.examples.Dockerfile", ['pytorch']),
     ("tensorflow.examples.Dockerfile", ['tensorflow']),
-    ("jupyter-ai.test.Dockerfile", ['jupyter-ai'])])
+    ("jupyter-ai.test.Dockerfile", ['jupyter-ai']),
+    ("jupyter-lsp.test.Dockerfile", ['jupyter-lsp']),
+    ("jupyter-lsp-server.test.Dockerfile", ['jupyter-lsp-server']),
+    ("notebook.test.Dockerfile", ['notebook'])])
 def test_dockerfiles_for_gpu(dockerfile_path: str, required_packages: List[str],
                              local_image_version: str, use_gpu: bool):
     _validate_docker_images(dockerfile_path, required_packages, local_image_version, use_gpu, 'gpu')