Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds eventlistener support via document.createEvent #135

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jeremyblalock
Copy link

Addresses: #134

Problem

As mentioned in the issue, you currently can't listen for changes on a polyfilled input. This is problematic if you're using React and other frameworks, since the React state & the state of the input will get out of sync.

Solution

I have added a few lines of code to trigger an event that will closely mirror the event that would come from an actual date input in Chrome / Firefox.

  • I have chosen to use the older document.createEvent interface, since it has wider support with browsers that are lacking the date input, and it has better compatibility with React
  • I have tested this with React, as well as a vanilla input.addEventListener, and both worked successfully.

@jeremyblalock
Copy link
Author

Note: I have already published this change here for my personal use: https://www.npmjs.com/package/@inventora/better-dateinput-polyfill

Feel free to test using that version. I am merely contributing this back because it was useful to fix my issue, and I thought others could benefit!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant