ref(bot): replace linters with ruff

bot/.vscode/settings.json

@@ -9,6 +9,9 @@
   "python.testing.pytestArgs": ["kodiak"],
   "python.testing.unittestEnabled": false,
   "python.testing.pytestEnabled": true,
-  "python.linting.flake8Enabled": true,
-  "python.linting.pylintEnabled": true
+  "python.linting.flake8Enabled": false,
+  "evenBetterToml.schema.enabled": false,
+  "[toml]": {
+    "editor.formatOnSave": false
+  }
 }

bot/README.md

@@ -13,7 +13,7 @@ The follow shows how to run commands for testing and development. For informatio
 poetry config virtualenvs.in-project true
 poetry install
 
-# format and lint using black, isort, mypy, flake8, pylint
+# format and lint
 s/lint
 
 # run tests using pytest
@@ -36,6 +36,7 @@ s/dev-workers
 ```
 
 If you have made any changes concerning the config, run the following command to update the schema:
+
 ```shell
 poetry run kodiak gen-conf-json-schema > kodiak/test/fixtures/config/config-schema.json
 ```

bot/kodiak/cli.py

@@ -34,10 +34,10 @@ def list_installs() -> None:
         private_key=conf.PRIVATE_KEY, app_identifier=conf.GITHUB_APP_ID
     )
     results: List[Dict[str, Any]] = []
-    headers = dict(
-        Accept="application/vnd.github.machine-man-preview+json",
-        Authorization=f"Bearer {app_token}",
-    )
+    headers = {
+        "Accept": "application/vnd.github.machine-man-preview+json",
+        "Authorization": f"Bearer {app_token}",
+    }
     url = conf.v3_url("/app/installations")
     while True:
         res = requests.get(url, headers=headers)

bot/kodiak/config.py

@@ -140,7 +140,7 @@ class Approve(BaseModel):
     auto_approve_labels: List[str] = []
 
 
-class InvalidVersion(ValueError):
+class InvalidVersion(ValueError):  # noqa: N818
     pass
 
 

bot/kodiak/entrypoints/ingest.py

@@ -35,7 +35,7 @@
 
 
 async def get_redis() -> asyncio_redis.Pool:
-    global _redis  # pylint: disable=global-statement
+    global _redis
     if _redis is None:
         _redis = await asyncio_redis.Pool.create(
             host=conf.REDIS_URL.hostname or "localhost",

bot/kodiak/entrypoints/worker.py

@@ -75,7 +75,7 @@ async def main() -> NoReturn:
     queue = RedisWebhookQueue()
     await queue.create()
 
-    ingest_workers = dict()
+    ingest_workers = {}
 
     redis = await redis_client.create_connection()
     ingest_queue_names = await redis.smembers(INGEST_QUEUE_NAMES)

bot/kodiak/errors.py

@@ -1,12 +1,12 @@
-class RetryForSkippableChecks(Exception):
+class RetryForSkippableChecks(Exception):  # noqa: N818
     pass
 
 
-class PollForever(Exception):
+class PollForever(Exception):  # noqa: N818
     pass
 
 
-class ApiCallException(Exception):
+class ApiCallException(Exception):  # noqa: N818
     def __init__(self, method: str, http_status_code: int, response: bytes) -> None:
         self.method = method
         self.status_code = http_status_code

bot/kodiak/evaluation.py

@@ -100,6 +100,7 @@ def get_body_content(
     if body_type is BodyText.html:
         return pull_request.bodyHTML
     assert_never(body_type)
+    return None
 
 
 EMPTY_STRING = ""

bot/kodiak/events/__init__.py

@@ -1,8 +1,8 @@
 from kodiak.events.check_run import CheckRunEvent  # noqa: F401
 from kodiak.events.pull_request import PullRequestEvent  # noqa: F401
 from kodiak.events.pull_request_review import PullRequestReviewEvent  # noqa: F401
-from kodiak.events.pull_request_review_thread import (  # noqa: F401
-    PullRequestReviewThreadEvent,
+from kodiak.events.pull_request_review_thread import (
+    PullRequestReviewThreadEvent,  # noqa: F401
 )
 from kodiak.events.push import PushEvent  # noqa: F401
 from kodiak.events.status import StatusEvent  # noqa: F401

bot/kodiak/http.py

@@ -2,15 +2,15 @@
 
 import ssl
 
-from httpx import (  # noqa: I251
+from httpx import (  # noqa: TID251
     AsyncClient,
     HTTPError,
     HTTPStatusError,
     Request,
     Response,
 )
-from httpx._config import DEFAULT_TIMEOUT_CONFIG  # noqa: I251
-from httpx._types import TimeoutTypes  # noqa: I251
+from httpx._config import DEFAULT_TIMEOUT_CONFIG  # noqa: TID251
+from httpx._types import TimeoutTypes  # noqa: TID251
 
 __all__ = ["Response", "Request", "HTTPError", "HttpClient", "HTTPStatusError"]
 

bot/kodiak/pull_request.py

@@ -267,7 +267,7 @@ async def update_branch(self) -> None:
             except HTTPError:
                 self.log.warning("failed to update branch", res=res, exc_info=True)
                 # we raise an exception to retry this request.
-                raise ApiCallException(
+                raise ApiCallException(  # noqa: B904
                     method="pull_request/update_branch",
                     http_status_code=res.status_code,
                     response=res.content,
@@ -329,9 +329,9 @@ async def merge(
                         "failed to merge pull request", res=res, exc_info=True
                     )
                 if e.response is not None and e.response.status_code == 500:
-                    raise GitHubApiInternalServerError
+                    raise GitHubApiInternalServerError  # noqa: B904
                 # we raise an exception to retry this request.
-                raise ApiCallException(
+                raise ApiCallException(  # noqa: B904
                     method="pull_request/merge",
                     http_status_code=res.status_code,
                     response=res.content,
@@ -351,7 +351,7 @@ async def update_ref(self, ref: str, sha: str) -> None:
                 else:
                     self.log.warning("failed to update ref", res=res, exc_info=True)
                 # we raise an exception to retry this request.
-                raise ApiCallException(
+                raise ApiCallException(  # noqa: B904
                     method="pull_request/update_ref",
                     http_status_code=res.status_code,
                     response=res.content,
@@ -376,7 +376,7 @@ async def add_label(self, label: str) -> None:
                 self.log.warning(
                     "failed to add label", label=label, res=res, exc_info=True
                 )
-                raise ApiCallException(
+                raise ApiCallException(  # noqa: B904
                     method="pull_request/add_label",
                     http_status_code=res.status_code,
                     response=res.content,
@@ -398,7 +398,7 @@ async def remove_label(self, label: str) -> None:
                     "failed to delete label", label=label, res=res, exc_info=True
                 )
                 # we raise an exception to retry this request.
-                raise ApiCallException(
+                raise ApiCallException(  # noqa: B904
                     method="pull_request/delete_label",
                     http_status_code=res.status_code,
                     response=res.content,