Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ButtonToggle): implement new icon variant of toggle #860

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat(ButtonToggle): implement new icon variant of toggle #860

wants to merge 4 commits into from

Conversation

masoudmanson
Copy link
Contributor

@masoudmanson masoudmanson commented Oct 3, 2024 •
edited
Loading

Summary

ButtonToggle
Github issue: #808

ButtonIcon component was found to have three distinct use cases:

  • Standard Button functionality
  • ButtonDropdown functionality
  • Toggle functionality, though used for distinctly different use cases than InputToggle

Use cases 1 and 2 above have resulted in the creation of Icon variants within the existing Button and ButtonDropdown components. Use case 3 has been implemented in this PR.

Checklist

  • Default Story in Storybook
  • LivePreview Story in Storybook
  • Test Story in Storybook
  • Tests written
  • Variables from defaultTheme.ts used wherever possible
  • If updating an existing component, depreciate flag has been used where necessary
  • Chromatic build verified by @chanzuckerberg/sds-design

@masoudmanson masoudmanson linked an issue Oct 3, 2024 that may be closed by this pull request
Implement: New icon variant of Toggle #808
Open
@masoudmanson masoudmanson self-assigned this Oct 3, 2024
clarsen-czi
clarsen-czi approved these changes Oct 3, 2024
View reviewed changes
Copy link

@clarsen-czi clarsen-czi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! Nicely done, @masoudmanson!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clarsen-czi clarsen-czi clarsen-czi approved these changes

@tihuan tihuan Awaiting requested review from tihuan

Assignees

@masoudmanson masoudmanson

Labels
Eng Feature Request P0 Ready for review This PR is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement: New icon variant of Toggle
2 participants
@masoudmanson @clarsen-czi