Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(borders): new thick and extraThick border variables #856

Conversation

masoudmanson
Copy link
Contributor

Summary

Bases
Github issue: #852 , #851

  • Updates the underlying primitive color for border variables on intent colors (beta, info, negative, notice and positive) to use the 600 shade instead of the 500 shade.
  • Introduces two new border variables for each intent color to support 2px and 4px wide borders.
  • Refactors the Notification component to replace the hardcoded 5px left border with the appropriate design token border variables.

…ick intent borders

Refactors Notification component to use border variables instead of hardcoded 5px border left
Copy link

@clarsen-czi clarsen-czi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @masoudmanson!! Thank you!

@masoudmanson masoudmanson merged commit 40afdc6 into main Oct 1, 2024
10 checks passed
@masoudmanson masoudmanson deleted the 852-create-new-border-variables-to-use-in-the-notification-and-intentmessage-components branch October 1, 2024 13:14
@masoudmanson masoudmanson added Ready for release This PR is ready for release and removed Ready for review This PR is ready for review labels Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Eng Ready for release This PR is ready for release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create new Border variables to use in the Notification and IntentMessage components
2 participants