Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Panel): implement panel component #850

Merged
merged 10 commits into from
Oct 1, 2024
Merged

feat(Panel): implement panel component #850

merged 10 commits into from
Oct 1, 2024

Conversation

masoudmanson
Copy link
Contributor

@masoudmanson masoudmanson commented Sep 25, 2024 •
edited
Loading

Summary

Panel
Github issue: #357

Checklist

  • Default Story in Storybook
  • LivePreview Story in Storybook
  • Test Story in Storybook
  • Tests written
  • Variables from defaultTheme.ts used wherever possible
  • If updating an existing component, depreciate flag has been used where necessary
  • Chromatic build verified by @chanzuckerberg/sds-design

@masoudmanson masoudmanson linked an issue Sep 25, 2024 that may be closed by this pull request
Implement: Panel component #357
Closed
@masoudmanson masoudmanson self-assigned this Sep 25, 2024
@masoudmanson masoudmanson added Work in Progress This PR is a work in progress Eng labels Sep 25, 2024
@masoudmanson masoudmanson added Ready for review This PR is ready for review and removed Work in Progress This PR is a work in progress labels Sep 26, 2024
tihuan
tihuan reviewed Sep 30, 2024
View reviewed changes
Copy link
Contributor

@tihuan tihuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the PR 👏 😄 Thanks so much for implementing this, Masoud! Just some small comments for discussions 🙏 PTAL thank you!!

packages/components/src/core/Panel/components/PanelHeaderClose/style.ts Outdated Show resolved Hide resolved
packages/components/src/core/Panel/index.tsx Outdated Show resolved Hide resolved
packages/components/src/core/Panel/index.tsx Show resolved Hide resolved
packages/components/src/core/Panel/index.tsx Outdated Show resolved Hide resolved
packages/components/src/core/Panel/index.tsx Outdated Show resolved Hide resolved
packages/components/src/core/Panel/style.ts Outdated Show resolved Hide resolved
packages/components/src/core/Panel/style.ts Outdated Show resolved Hide resolved
packages/components/src/core/Panel/style.ts Outdated Show resolved Hide resolved
packages/components/src/core/Panel/style.ts Outdated Show resolved Hide resolved
packages/components/src/core/Panel/__tests__/index.test.tsx Show resolved Hide resolved
@tihuan
Copy link
Contributor

tihuan commented Sep 30, 2024

Thanks for the reply, Masoud! ALSO, it's a holiday today!! Don't workkk and have fun with friends and family!! Work will be there tomorrow 😁 👌

clarsen-czi
clarsen-czi approved these changes Sep 30, 2024
View reviewed changes
Copy link

@clarsen-czi clarsen-czi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! Thanks @masoudmanson!

@masoudmanson
Copy link
Contributor Author

Thanks for the reply, Masoud! ALSO, it's a holiday today!! Don't workkk and have fun with friends and family!! Work will be there tomorrow 😁 👌

Oh, absolutely 😅 I saw your comments yesterday and got excited to reply right away. I made sure to enjoy the day off. Thanks for checking in! 🥳🎉😬😍🫠

@masoudmanson
Copy link
Contributor Author

LGTM!! Thanks @masoudmanson!

Thanks so much for the review, @clarsen-czi ! I really appreciate it 🥳🙏🏻🎉

@masoudmanson masoudmanson merged commit 486b2e7 into main Oct 1, 2024
10 checks passed
@masoudmanson masoudmanson deleted the 357-implement-panel-component branch October 1, 2024 13:21
@masoudmanson masoudmanson added Ready for release This PR is ready for release and removed Ready for review This PR is ready for review labels Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tihuan tihuan tihuan left review comments

@clarsen-czi clarsen-czi clarsen-czi approved these changes

Assignees

@masoudmanson masoudmanson

Labels
Eng Ready for release This PR is ready for release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement: Panel component
3 participants
@masoudmanson @tihuan @clarsen-czi