Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENT-4400: Allowed blob image-src in the Mission Portal CSP rules #2949

Merged
merged 1 commit into from
Oct 11, 2024
Merged

ENT-4400: Allowed blob image-src in the Mission Portal CSP rules #2949

merged 1 commit into from
Oct 11, 2024

Conversation

aleksandrychev
Copy link
Contributor

Highchart export requires it

@aleksandrychev
Allowed blob image-src in the Mission Portal CSP rules
4070af3 
Highchart export requires it

Signed-off-by: Ihor Aleksandrychiev <[email protected]>
craigcomstock
craigcomstock requested changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@craigcomstock craigcomstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this require the same change in buildscripts repo?

@aleksandrychev
Copy link
Contributor Author

Won't this require the same change in buildscripts repo?

@craigcomstock I don't see any of CSP rules there https://github.com/cfengine/buildscripts/blob/master/deps-packaging/apache/httpd.conf

@aleksandrychev
Copy link
Contributor Author

Won't this require the same change in buildscripts repo?

added whole rules set cfengine/buildscripts#1504

@craigcomstock craigcomstock mentioned this pull request Oct 11, 2024
Merged
@craigcomstock craigcomstock merged commit d94cee3 into cfengine:master Oct 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craigcomstock craigcomstock craigcomstock approved these changes

@nickanderson nickanderson Awaiting requested review from nickanderson

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aleksandrychev @craigcomstock