ENT-11136: Refactor and improve policy fixing up SELinux context on FR SSH files (3.21) #2890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to make sure both `semanage fcontext -a` and `restorecon`
are done before we run `ssh-keygen`. Otherwise `ssh-keygen` may
be blocked by SELinux when trying to save/write the generated
key at first and only succeeds in a later agent run.
Ticket: ENT-11136
Changelog: Federated reporting policy fixes SELinux context of
the ~cftransport/.ssh directory and its contents in a
single agent run.
(cherry picked from commit ff392a9)
|
For #2817 |
nickanderson
requested review from
vpodzime and
craigcomstock
and removed request for
vpodzime
|
@cf-bottom jenkins, please |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/10818/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-10818/ |
vpodzime
approved these changes
May 27, 2024
craigcomstock
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to make sure both
semanage fcontext -aandrestoreconare done before we run
ssh-keygen. Otherwisessh-keygenmaybe blocked by SELinux when trying to save/write the generated
key at first and only succeeds in a later agent run.
Ticket: ENT-11136
Changelog: Federated reporting policy fixes SELinux context of
the ~cftransport/.ssh directory and its contents in a
single agent run.
(cherry picked from commit ff392a9)