CFE-4342: When failing to detect platform, inventory attribute "OS" now defaults to PRETTY_NAME from os-release as a fallback #2850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olehermanse
requested review from
nickanderson,
craigcomstock,
vpodzime and
larsewi
olehermanse
changed the title
…s to PRETTY_NAME from os-release as a fallback This is only a fallback / last resort, in the case where the C code puts "Unknown" into the sys.os_name_human variable. Also adding a warning to the agent in this case: cfengine/core#5460 Ticket: CFE-4342 Changelog: Title Signed-off-by: Ole Herman Schumacher Elgesem <[email protected]>
larsewi
approved these changes
Feb 28, 2024
nickanderson
approved these changes
Feb 28, 2024
craigcomstock
approved these changes
Feb 28, 2024
olehermanse
added
the
cherry-pick?
|
Cherry-pick: #2893 |
olehermanse
removed
cherry-pick?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge together:
cfengine/core#5460
#2850