Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENT-11988: Atomic copy_from in files promise (3.21.x) #5614

Merged
merged 5 commits into from
Oct 14, 2024

Commits on Oct 10, 2024

  1. Atomic copy_from in files promise

    Changes to `files` promise in `copy_from` attribute:
    
    - The new file (i.e., `<FILENAME>.cfnew`) is now created with correct
      permission during remote copy. Previously it would be created with
      default permissions.
    - The destination file (i.e., `<FILENAME>`) is no longer deleted on
      backup during file copy.  Previously it would be renamed to
      `<FILENAME>.cfsaved`, causing the original file to dissappear. Now an
      actual copy of the original file with the same permissions is created
      instead.
    
    As a result, there will no longer be a brief moment where the original
    file is inaccessible.
    
    Ticket: ENT-11988
    Changelog: Commit
    Signed-off-by: Lars Erik Wik <[email protected]>
    (cherry picked from commit 224ccc3)
    larsewi committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    23bb68a View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. Workaround cppcheck ignoring -i libpromises/cf3lex.c

    When running cppcheck in static checks, we use `-i
    libpromises/cf3lex.c` in order to make cppcheck ignore the
    generated cf3lex.c file. However, the new version of cppcheck
    ignores this option and fails on issues found in the file.
    
    However, we don't want this file or any other generated files
    except for bootstrap.inc which contains the bootstrap policy. So
    we can run `make clean` and `make -C libpromise/ boostrap.inc`
    before running cppcheck to get a cleaner environment.
    
    (cherry picked from commit e9cfa41)
    Signed-off-by: Lars Erik Wik <[email protected]>
    vpodzime authored and larsewi committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    9d0fd65 View commit details
    Browse the repository at this point in the history
  2. Fixed failure to install cf-remote

    ```
    error: externally-managed-environment
    ```
    
    Since this is a container, it should be OK to potentially break system
    packages.
    
    Ticket: None
    Changelog: None
    Signed-off-by: Lars Erik Wik <[email protected]>
    (cherry picked from commit 0195e21)
    larsewi committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    2805fb1 View commit details
    Browse the repository at this point in the history
  3. Fixed error in static checks

    libncurses5 was not available in the noble repository, but maybe
    libncurses6 will work.
    
    ```
    E: Unable to locate package libncurses5
    ```
    
    Ticket: None
    Changelog: None
    Signed-off-by: Lars Erik Wik <[email protected]>
    (cherry picked from commit 4d1944a)
    larsewi committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    526d710 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. Fixed missing PCRE in CodeQL test

    ```
    checking for pcre_exec in -lpcre... no
    configure: error: Cannot find PCRE
    ```
    
    Ticket: None
    Changelog: None
    Signed-off-by: Lars Erik Wik <[email protected]>
    larsewi committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    18c1873 View commit details
    Browse the repository at this point in the history