Log errors for commands promises with exit codes not matching any _returncodes #5599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…turncodes
They are marked as failed with the following message:
Command related to promiser '...' returned code '1' not defined as promise kept, not kept or repaired; setting to failed
Failed promises should log errors not just info
messages. Otherwise running without `--info` or more detailed
logging fails silently.
Ticket: CFE-4429
Ticket: ENT-12103
Changelog: commands promises with exit codes not matching any
_returncodes attributes from classes body now log and
error message not just an info message
vpodzime
changed the title
|
smoke test: |
craigcomstock
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are marked as failed with the following message:
Failed promises should log errors not just info
messages. Otherwise running without
--infoor more detailed logging fails silently.Ticket: CFE-4429
Ticket: ENT-12103
Changelog: commands promises with exit codes not matching any
_returncodes attributes from classes body now log and
error message not just an info message