[3.21.x] valgrind-checks improvements #5570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It can be really slow (testing showed up to a minute). Ticket: CFE-4416 Changelog: None (cherry picked from commit e07820e)
To speed builds up. Ticket: CFE-4416 Changelog: None (cherry picked from commit 733e12e)
If things go wrong and a run of valgrind-checks gets stuck, it's hard to terminate and clean after it properly because it runs as root. In a container, but that doesn't make a difference. To avoid such issues, let's make sure the `bash` process running the valgrind checks kills itself after a period of time unless it finishes properly (succeeding or failing). Ticket: CFE-4416 Changelog: None (cherry picked from commit 079c633)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #5567