CFE-4408: Fixed package promises with only promisers and no other attributes #5552
Conversation
|
github CI is green, let's try jenkins @cf-bottom, thanks! |
craigcomstock
force-pushed
the
CFE-4408/master
branch
from
0ff6857
to
72d6ff6
Compare
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/10972/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-10972/ |
|
@cf-bottom jenkins on lots of platforms to check this change. |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/10988/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-10988/ |
|
CI was unstable but won't really test this fix anyway. I will manually test packages generated. I don't think there is a reliable way to automate a test since it depends on actual packages. |
craigcomstock
force-pushed
the
CFE-4408/master
branch
from
72d6ff6
to
07177f7
Compare
|
get a package with these changes |
|
This will also fix: https://northerntech.atlassian.net/browse/CFE-4398 |
craigcomstock
force-pushed
the
CFE-4408/master
branch
from
07177f7
to
804817d
Compare
|
@basvandervlies maybe take another look at this PR. I have done some testing and think it is good and like you said should resolve two bugs with one stone! 😹 |
craigcomstock
force-pushed
the
CFE-4408/master
branch
from
dc2feb7
to
930fb46
Compare
|
@cf-bottom jenkins exotics please |
|
Alright, I triggered a build: (with exotics) Jenkins: https://ci.cfengine.com/job/pr-pipeline/11047/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-11047/ |
|
Only failure in CI is process_test on rhel-7, known issue https://northerntech.atlassian.net/browse/ENT-10994 |
…ributes CFE-4315 introduced a behavior change so that in the case of a simple package promise with only a promiser: packages: "ed"; Things would just work in the case where there was no default package manager defined with package_module_knowledge.platform_default. In the case where package_module_knowledge.platform_default was defined this simple case would cause errors. This change fixes this second case as well as improves logging around the choosing of v1 and v2 package promise implementations. Some of these changes fix CFE-4398 which noted that too many INFO level messages were produced. These messages are moved to DEBUG and VERBOSE level as appropriate. Also added "packages" promises to list of exceptions so that a bare promiser-only package promise does not cause warnings. Ticket: CFE-4408 Changelog: title
craigcomstock
force-pushed
the
CFE-4408/master
branch
from
930fb46
to
8961a77
Compare
|
cherry picked to 3.21.x: #5573 |
CFE-4315 introduced a behavior change so that in the case of a simple package promise with only a promiser:
packages:
"ed";
Things would just work in the case where there was no default package manager defined with package_module_knowledge.platform_default.
In the case where package_module_knowledge.platform_default was defined this simple case would cause errors.
This change fixes this second case as well as modifies and adds some logging around the choosing of v1 or v2 package promise implementation.
Ticket: CFE-4408
Changelog: title