ENT-9491: Fixed bug in double expansion of foreign list variables #5536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for submitting a PR! Maybe @craigcomstock can review this? |
larsewi
force-pushed
the
expand
branch
4 times, most recently
from
222fcf5
to
3f1c774
Compare
Ticket: None Changelog: None Signed-off-by: Lars Erik Wik <[email protected]>
Ticket: None Changelog: None Signed-off-by: Lars Erik Wik <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
larsewi
force-pushed
the
expand
branch
3 times, most recently
from
1ad9041
to
ae785aa
Compare
larsewi
changed the title
vpodzime
approved these changes
Jun 28, 2024
There was a problem hiding this comment.
Very well done, sir! 👏 🍻 I'd just squash the last two commits because it doesn't make sense to cherry-pick one without the other. We would have to mark the test as soft-failing and then remove that together with the fix, but I think that's just extra unnecessary work.
Test output before fix looks like this: ``` R: /ntech/cfengine/core/tests/acceptance/01_vars/01_basic/double_expansion_list.cf FAIL R: $($(parent_bundle).str) => EXPANDED R: $($(parent_bundle).lst) => $(check.lst) R: $(check.baz) => EXPANDED R: $($(parent_bundle)$lst) => EXPANDED ``` Ticket: ENT-9491 Changelog: None Signed-off-by: Lars Erik Wik <[email protected]>
larsewi
added
the
cherry-pick?
This was referenced Jun 28, 2024
larsewi
removed
the
cherry-pick?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back-ported to: