ENT-10428: Removed push event handling in github actions workflow (3.18) #5291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't have easy visibility on the results of these events which only occur after we merge pull requests. We use /merge refs in pull requests so running the actions again on push events (after the merge) don't really provide any additional information. Pushes/commits to pull requests are handled by the pull_request event so no change there. See https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#push Ticket: ENT-10428 Changelog: none (cherry picked from commit 81b49e7) Conflicts: .github/workflows/ci.yml Different branches were mentioned in push event handling but we removed it entirely so no significant conflict.
|
from #5290 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't have easy visibility on the results of these events which only occur after we merge pull requests.
We use /merge refs in pull requests so running the actions again on push events (after the merge) don't really provide any additional information.
Pushes/commits to pull requests are handled by the pull_request event so no change there.
See https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#push
Ticket: ENT-10428
Changelog: none
(cherry picked from commit 81b49e7)
Conflicts:
.github/workflows/ci.yml
Different branches were mentioned in push event handling but we removed it entirely so no significant conflict.