investigate windows crlf issues #5289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for submitting a pull request! Maybe @olehermanse can review this? |
Lex-2008
force-pushed
the
ENT-10254-windows-crlf
branch
4 times, most recently
from
cfc7e9c
to
a514f1d
Compare
added 3 commits
July 27, 2023 14:22
It was a temporary workaround to make some tests pass on Windows Ticket: ENT-10254 Changelog: none
After removing .gitattributes file, some tests started passing Ticket: ENT-10254 Changelog: none
Also install dos2unix for this and remove cf-secret workaround, since we package it now Ticket: ENT-10433 Changelog: none
Lex-2008
force-pushed
the
ENT-10254-windows-crlf
branch
from
a514f1d
to
9a9d10d
Compare
craigcomstock
approved these changes
Jul 27, 2023
nickanderson
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: ENT-10254