Fixes for libntech without GPL code #5282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vpodzime
force-pushed
the
master-with_pcre
branch
3 times, most recently
from
f0f50c7
to
b60f2e5
Compare
vpodzime
changed the title
vpodzime
force-pushed
the
master-with_pcre
branch
3 times, most recently
from
3607096
to
c59864b
Compare
vpodzime
force-pushed
the
master-with_pcre
branch
from
b756bc3
to
062ae93
Compare
|
Thank you for submitting a PR! Maybe @olehermanse can review this? |
vpodzime
force-pushed
the
master-with_pcre
branch
from
062ae93
to
d4834dc
Compare
Because libntech uses our config.h.
vpodzime
force-pushed
the
master-with_pcre
branch
2 times, most recently
from
045ead3
to
beffbb2
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
vpodzime
force-pushed
the
master-with_pcre
branch
2 times, most recently
from
c4245ab
to
39017ac
Compare
With GPL-licensed code taken from libntech/libcompat. This also means that we have to leave all the function-replacing macros to libntech/configure, but that's the correct thing to do because libcompat is part of libntech and so libntech/configure actually determines which fuctions/code will be part of libcompat. The only exception are the *printf() functions because their replacements are handled by special macros (see m4/snprintf.m4 for gore details) and we need those bits to happen in this repo too.
So that we can make decisions based on it in our Makefile.am files.
We have a wrapper function that checks that memory allocation was successful. Plus our function is available in our header file and in our utility library for the linker so we don't have to bother (in this code) where it comes from.
It could be used to print data from the process' memory. Not really important in cf-testd, but we should stick to good and safe coding practices anyway.
vpodzime
force-pushed
the
master-with_pcre
branch
from
39017ac
to
caa27a3
Compare
|
@cf-bottom jenkins with exotics, please |
|
Sure, I triggered a build: (with exotics) Jenkins: https://ci.cfengine.com/job/pr-pipeline/9632/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-9632/ |
|
@cf-bottom jenkins with exotics, please |
vpodzime
force-pushed
the
master-with_pcre
branch
from
c518db0
to
b2c8966
Compare
vpodzime
force-pushed
the
master-with_pcre
branch
from
b2c8966
to
a43e382
Compare
Our version may not be 100 % compatible or at least not 100 % optimal for the given system.
vpodzime
force-pushed
the
master-with_pcre
branch
from
a43e382
to
76f1f02
Compare
|
Alright, I triggered a build: (with exotics) Jenkins: https://ci.cfengine.com/job/pr-pipeline/9651/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-9651/ |
larsewi
reviewed
Aug 2, 2023
larsewi
approved these changes
Aug 2, 2023
olehermanse
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge together:
#5282
NorthernTechHQ/libntech#186