Skip to content

Commit

Permalink
Removed push event handling in github actions workflow
Browse files Browse the repository at this point in the history
We don't have easy visibility on the results of these events
which only occur after we merge pull requests.
We use /merge refs in pull requests so running the actions again on push events (after the merge) don't really provide any additional information.

Pushes/commits to pull requests are handled by the pull_request event so no change there.

See https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#push

Ticket: ENT-10428
Changelog: none
  • Loading branch information
craigcomstock committed Jul 14, 2023
1 parent 47e72cb commit 81b49e7
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,6 @@ on:
pull_request:
branches: [ master, 3.21.x, 3.18.x ]

# run this workflow on push/merge activity
# pull_request activity won't detect changes
# in the upstream branch before we merge
push:
branches: [ master, 3.21.x, 3.18.x ]


jobs:
unit_tests:
uses: ./.github/workflows/unit_tests.yml
Expand Down

0 comments on commit 81b49e7

Please sign in to comment.