Fix rbd.image scan stuck #185
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yaohui.zhou <[email protected]> update 3 patches: patch 1 - fix the close/lock issues. This patch fixes an issue where the common.py is cleaning the ioctx open if a lock call fails. patch 2 - fix the error_msg issue. This patch fixes an issue where we are not checking for config commit errors and returning a error_msg in a couple places. patch 3 - fix the rbd.image scan stuck issue. This patch fixes an issue where the pool is full, the code "with rbd.Image (ioctx, image) as rbd_image:" in gwcli will get stuck.
dillaman
reviewed
Aug 20, 2020
| @@ -482,13 +482,12 @@ def unlock(self): | |||
|
|
|||
| def _seed_rbd_config(self): | |||
|
|
|||
| ioctx = self._open_ioctx() | |||
There was a problem hiding this comment.
Nit: perhaps just use a with self._open_ioctx() as ioctx: block ....
dillaman
reviewed
Aug 20, 2020
| @@ -591,15 +591,14 @@ def set_item(self, cfg_type, element_name, element_value): | |||
|
|
|||
| def _commit_rbd(self, post_action): | |||
|
|
|||
| ioctx = self._open_ioctx() | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: yaohui.zhou [email protected]
update 3 patches:
patch 1 - fix the close/lock issues. This patch fixes an issue where the common.py is cleaning the ioctx open if a lock call fails.
patch 2 - fix the error_msg issue. This patch fixes an issue where we are not checking for config commit errors and returning a error_msg in a couple places.
patch 3 - fix the rbd.image scan stuck issue. This patch fixes an issue where the pool is full, the code "with rbd.Image (ioctx, image) as rbd_image:" in gwcli will get stuck.