This repository has been archived by the owner on Nov 18, 2021. It is now read-only.
Tune react/jsx-curly-brace-presence #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* For _children_, I think we enable this. but the current rule impl. is pretty buggy and noisey. It's better to disable it. * For _props_, inn JSX syntax, `props` is not a string in many cases. And in plain JavaScript worlds, we don't have any static type checks, we need think about whether we should add a bracket or not by the type of props. It's pretty tired thing. For sorting style and avoid this tired thing, I prefer to write bracket always.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
but the current rule impl. is pretty buggy and noisey. It's better to disable it.
propsis not a string in many cases.And in plain JavaScript worlds, we don't have any static type checks,
we need think about whether we should add a bracket or not by the type of props.
It's pretty tired thing.
For sorting style and avoid this tired thing, I prefer to write bracket always.
#41