fix(anilist): change text-bright, cleanup #1458
Open
+16
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnubisNekhet
commented
Nov 15, 2024
Comment on lines
+28
to
+37
| // Scrollbar color | ||
| * { | ||
| scrollbar-color: @catppuccin[@@lightFlavor][@@accentColor] | ||
| fade(@catppuccin[@@darkFlavor][@crust], 0.2); | ||
| &:has(.site-theme-dark) { | ||
| scrollbar-color: @catppuccin[@@darkFlavor][@@accentColor] | ||
| fade(@catppuccin[@@darkFlavor][@crust], 0.2); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
I'm not completely sure if this will be fine performance-wise, but it's the only way I could style the scrollbars.
There was a problem hiding this comment.
Why does it need to be applied to every single element? And why is this not in the #catppuccin mixin?
There was a problem hiding this comment.
The userstyle uses the body element to select dark and light flavors, which unfortunately results in the scrollbar (Which is styled using the * selector) not being themed. It's the only way I could figure out a workaround, however I'm open to any changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes default value of
--color-text-bright, removes redundant styling