Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(searxng): make links blue and visited links mauve #1450

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

DokterKaj
Copy link
Contributor

@DokterKaj DokterKaj commented Nov 14, 2024

🔧 What does this fix? 🔧

As the title says, distinguishes links from visited links by making them blue and mauve respectively instead of all being the accent colour.

🗒 Checklist 🗒

  • I have read and followed Catppuccin's contributing guidelines.
  • I have updated the version appropriately in the ==UserStyle== header of the catppuccin.user.css file.

@uncenter
Copy link
Member

The default accent is always the same across websites, we don't change it for specific userstyles.

@DokterKaj
Copy link
Contributor Author

In that case it's probably best to hard-code links as blue

Should visited links be hard-coded as mauve or be accented?

@DokterKaj DokterKaj marked this pull request as draft November 14, 2024 16:06
@uncenter
Copy link
Member

Well, according to the style guide visited/followed links would be lavender I believe, not mauve. We haven't made a complete decision on accent links vs style guide links yet, it is likely up to the maintainer to decide which they think looks better for a specific userstyle.

@DokterKaj
Copy link
Contributor Author

Lavender is not quite distinct enough from blue at a glance, so I think I'll still go with mauve like the Brave and DDG userstyles.

@DokterKaj
Copy link
Contributor Author

Not sure where --color-result-detail-link is used but it has "link" in the name so best to make it blue anyway

@DokterKaj DokterKaj changed the title feat(searxng): visited link colour + change default accent to blue feat(searxng): make links blue and visited links mauve Nov 14, 2024
@DokterKaj DokterKaj marked this pull request as ready for review November 14, 2024 17:15
@sgoudham
Copy link
Contributor

sgoudham commented Nov 14, 2024

Just my two cents, I don't think we should accept a contribution that is against the style guide. We're not making a tradeoff to improve some other highlight in this case either.

Also it does make this userstyles inconsistent with the others. As it stands, none of the userstyles support differentiation between links, on hover and visited so we'd probably just have to encourage users to make local changes if they want that at the minute. I stand corrected, apparently we do make some modifications for links on hover.

In the future, we can probably look towards supporting this with official shades? Curious what @isabelroses and @uncenter think.

@DokterKaj
Copy link
Contributor Author

Just my two cents, I don't think we should accept a contribution that is against the style guide.

Do the other browser userstyles have to have visited links be changed to lavender then?

We're not making a tradeoff to improve some other highlight in this case either.

Not quite clear on what this means, sorry

@sgoudham
Copy link
Contributor

Do the other browser userstyles have to have visited links be changed to lavender then?

I believe the style guide wasn't necessarily followed here since lavender itself is offered as an accent colour. I don't think it's feasible to update all the userstyles to that.

We'll probably have to define official shades of colours as part of the style guide so that userstyles can standardise on the amount to lighten/darken the links for hover/visited.

Not quite clear on what this means, sorry

Sorry ignore me there, what I said wasn't really relevant.

@DokterKaj
Copy link
Contributor Author

I believe the style guide wasn't necessarily followed here since lavender itself is offered as an accent colour.

This shouldn't be a problem since this PR would make links no longer accented; they'd just be blue and mauve (or blue and lavender, if we must adhere to the style guide) so there shouldn't be any clashing.

We'll probably have to define official shades of colours as part of the style guide so that userstyles can standardise on the amount to lighten/darken the links for hover/visited.

That would be ideal, but for now this is probably the best way to re-add this functionality of distinguishing visited links.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
searxng SearXNG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants