Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kotlin): init #1309

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat(kotlin): init #1309

wants to merge 6 commits into from

Conversation

thelooter
Copy link

🎉 Theme for Kotlin 🎉

preview

The Kotlin website offers resources for learning and using Kotlin, a modern, multiplatform programming language. It highlights Kotlin's key features, including simplicity, Java compatibility, and usage across platforms like Android, web, and server-side development.

💬 Additional Comments 💬

The website doesn't offer an official light mode, therefore latte support needs to be selected via the dark mode menu.

🗒 Checklist 🗒

  • I have read and followed Catppuccin's submission guidelines.
  • I have made a new directory underneath /styles/<name-of-website> containing the contents of the /template directory.
    • I have ensured that the new directory is in lower-kebab-case.
    • I have followed the template and kept the preprocessor as LESS.
  • I have made sure to update the
    userstyles.yml
    file with information about the new userstyle.
  • I have included the following files:
    • catppuccin.user.css - all the CSS for the userstyle, based on the
      template.
    • preview.webp - composite image of all four individual flavor screenshots (taken with the default accent color of mauve) stitched together, generated via Catwalk.

@thelooter thelooter requested a review from a team as a code owner September 14, 2024 21:30
styles/kotlin/catppuccin.user.css Outdated Show resolved Hide resolved
styles/kotlin/catppuccin.user.css Outdated Show resolved Hide resolved
styles/kotlin/catppuccin.user.css Outdated Show resolved Hide resolved
styles/kotlin/catppuccin.user.css Outdated Show resolved Hide resolved
styles/kotlin/catppuccin.user.css Outdated Show resolved Hide resolved
styles/kotlin/catppuccin.user.css Outdated Show resolved Hide resolved
styles/kotlin/catppuccin.user.css Show resolved Hide resolved
Copy link
Member

@uncenter uncenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hover text of nav subitems is unthemed.

CleanShot 2024-10-02 at 22 10 01

Boxes with borders do not have correctly themed border colors on hover.

CleanShot 2024-10-02 at 22 11 13

Line numbers, expand/hide buttons, open in playground text,and run button of code samples unthemed (https://kotlinlang.org/docs/basic-syntax.html#functions).

CleanShot 2024-10-02 at 22 13 43

These note callouts have unthemed text (https://kotlinlang.org/docs/typecasts.html).

CleanShot 2024-10-02 at 22 14 56

Slashes in breadcrumbs unthemed.

CleanShot 2024-10-02 at 22 15 59

Playground is actually mostly themed, just this toolbar and output box are not themed.

CleanShot 2024-10-02 at 22 17 36

Search box unthemed.

CleanShot 2024-10-02 at 22 18 12

API docs are unthemed (the old styling - https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/ - looks bad, you could prob just theme the new https://kotlinlang.org/api/core/kotlin-stdlib/)

Signed-off-by: thelooter <[email protected]>
- Add prismjs import
- Remove data theme selector
- Restore default theming options
- Make Prompts lighter and switch them to crust text
- Change Prompt icons to crust
- Restore condensed catppuccin block
@uncenter
Copy link
Member

No need to force push FYI. Commit history in here doesn't matter since we squash merge all PRs.

@uncenter
Copy link
Member

Just want to make sure I don't miss this - let me know if you are ready for me to re-review. If the previously mentioned issues are fixed we should be good to merge.

@thelooter
Copy link
Author

Just want to make sure I don't miss this - let me know if you are ready for me to re-review. If the previously mentioned issues are fixed we should be good to merge.

I have styled the old API Docs, the new ones are yet to be done. Will take a little bit more time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants