Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WD-7913] support portal legal pages #13426

Merged

Conversation

akbarkz
Copy link
Contributor

@akbarkz akbarkz commented Jan 4, 2024

Done

QA

Issue / Card

Fixes https://warthogs.atlassian.net/browse/WD-7913

Help

QA steps - Commit guidelines

@webteam-app
Copy link

Demo starting at https://ubuntu-com-13426.demos.haus

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9a6e77e) 74.41% compared to head (f5376e0) 74.41%.
Report is 30 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13426   +/-   ##
=======================================
  Coverage   74.41%   74.41%           
=======================================
  Files         107      107           
  Lines        2838     2838           
  Branches      946      946           
=======================================
  Hits         2112     2112           
  Misses        702      702           
  Partials       24       24           

@Sophie-32
Copy link

Sophie-32 commented Jan 4, 2024

For https://ubuntu-com-13426.demos.haus/legal/data-privacy/support-portal

  1. Can I make some spacing recommendations for the first paragraph?
  2. I suggest a table of contents to help readers see what's on this page and navigate through it more quickly.

For https://ubuntu-com-13426.demos.haus/legal/terms-and-policies/support-portal

  1. The titles of the pages are inconsistent, since these pages are just for the Canonical support portal, I suggest the headers start with that, and then provide the secondary information 'Privacy notice' and 'Terms of service' - otherwise readers may interpret this as the privacy notice and terms of service for ALL of Canonical.

@akbarkz
Copy link
Contributor Author

akbarkz commented Jan 4, 2024

@Sophie-32 Thanks for having a look. Your suggestions make total sense, however these 2 new pages are implemented in accordance to every other similar page under /legal/data-privacy and /legal/terms-and-policies. If we are to change the new ones, I believe we need to change all the other existing ones the same way.
Considering the urgency of this task I suggest we leave it as it is, but feel free to contact Lydia and suggest your changes. If she agrees we can add another task to our backlog. Wdyt?

@Sophie-32
Copy link

@Sophie-32 Thanks for having a look. Your suggestions make total sense, however these 2 new pages are implemented in accordance to every other similar page under /legal/data-privacy and /legal/terms-and-policies. If we are to change the new ones, I believe we need to change all the other existing ones the same way. Considering the urgency of this task I suggest we leave it as it is, but feel free to contact Lydia and suggest your changes. If she agrees we can add another task to our backlog. Wdyt?

Yes that makes sense!

Copy link
Contributor

@carkod carkod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I couldn't compare with the other two copy docs because I didn't have permission to view them. I think you may want to add at least view permissions next time you create a copy doc, or maybe it's a folder issue.

@akbarkz akbarkz merged commit f0e111d into canonical:main Jan 5, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants