cmd/snap-update-ns: allow detaches to propagate #14545
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When snap-update-ns chooses not to reuse a mount entry it attempts to unmount it by detaching the mount entry. Before that is done the mount entry used to be switch to private propagation, so that the unmount operation was isolated. Disable this logic so that unmounts (and detaches) propagate normally. The mount namespace of the snap is mostly switched to slaved propagation, with the sole exception of /media or /run/media, which uses bidirectional propagation by design. This patch is experimental and is not ready for being merged yet. Jira: https://warthogs.atlassian.net/browse/SNAPDENG-31645 Signed-off-by: Zygmunt Krynicki <[email protected]>
zyga
force-pushed
the
fix/allow-detaches-to-propagate-SNAPDENG-31645
branch
from
66d7f1b
to
096a8f9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14545 +/- ##
==========================================
+ Coverage 78.85% 78.87% +0.01%
==========================================
Files 1079 1080 +1
Lines 145615 145817 +202
==========================================
+ Hits 114828 115009 +181
- Misses 23601 23616 +15
- Partials 7186 7192 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When snap-update-ns chooses not to reuse a mount entry it attempts to unmount it by detaching the mount entry. Before that is done the mount entry used to be switch to private propagation, so that the unmount operation was isolated.
Disable this logic so that unmounts (and detaches) propagate normally. The mount namespace of the snap is mostly switched to slaved propagation, with the sole exception of /media or /run/media, which uses bidirectional propagation by design.
This patch is experimental and is not ready for being merged yet.
Jira: https://warthogs.atlassian.net/browse/SNAPDENG-31645