Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interfaces: add support for snapped pipewire #14453

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

sergio-costas
Copy link
Contributor

@sergio-costas sergio-costas commented Sep 2, 2024

A snapped pipewire requires to be able to create the pulse folder inside the global XDG_RUNTIME_DIR folder (not the snap own folder). Also, it requires to be able to create both the pipewire-[0-9]-manager and its lock file.

This patch adds that capability to the new pipewire interface, and also modifies the audio-playback interface; thus, a snap offering those slots will be able to create the corresponding global sockets, and a snap using them will be able to access the global ones.

This patch is required to snap pipewire, which is a must for Core Desktop: https://github.com/sergio-costas/pipewire-snap

Thanks for helping us make a better snapd!
Have you signed the license agreement and read the contribution guide?

@sergio-costas sergio-costas changed the title Add support for snapped pipewire audio-playback: add support for snapped pipewire Sep 2, 2024
@sergio-costas sergio-costas force-pushed the add-support-for-snapped-pipewire branch 2 times, most recently from c68d907 to f9eafac Compare September 2, 2024 11:17
@sergio-costas sergio-costas marked this pull request as draft September 2, 2024 11:28
@sergio-costas sergio-costas marked this pull request as ready for review September 2, 2024 14:39
@ernestl ernestl added this to the 2.66 milestone Sep 2, 2024
@sergio-costas sergio-costas marked this pull request as draft September 6, 2024 09:26
@sergio-costas sergio-costas changed the title audio-playback: add support for snapped pipewire interfaces: add support for snapped pipewire Sep 6, 2024
A snapped pipewire requires being able to create the pulse
folder inside the global XDG_RUNTIME_DIR folder (not the snap
own folder). Also, it requires to be able to create both the
pipewire-[0-9]-manager and its lock file.

This patch adds that capability to the audio-playback slot;
thus, a snap offering that slot will be able to create the
corresponding global sockets.
@ernestl
Copy link
Collaborator

ernestl commented Sep 19, 2024

@sergio-costas, this is not targetting 2.66 release anymore, let me know if you want to discuss

@sergio-costas
Copy link
Contributor Author

Thanks @ernestl. This is still a work in progress, and there's no hurry. I just uploaded here as a draft to ensure that it doesn't end in "limbo", since all the testing and work is being done in our core desktop snapd branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants