-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
interfaces: add support for snapped pipewire #14453
Draft
sergio-costas
wants to merge
9
commits into
canonical:master
Choose a base branch
from
sergio-costas:add-support-for-snapped-pipewire
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
interfaces: add support for snapped pipewire #14453
sergio-costas
wants to merge
9
commits into
canonical:master
from
sergio-costas:add-support-for-snapped-pipewire
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergio-costas
force-pushed
the
add-support-for-snapped-pipewire
branch
from
September 2, 2024 10:49
3ea3b52
to
269d204
Compare
sergio-costas
changed the title
Add support for snapped pipewire
audio-playback: add support for snapped pipewire
Sep 2, 2024
sergio-costas
force-pushed
the
add-support-for-snapped-pipewire
branch
2 times, most recently
from
September 2, 2024 11:17
c68d907
to
f9eafac
Compare
sergio-costas
force-pushed
the
add-support-for-snapped-pipewire
branch
from
September 6, 2024 12:28
f9eafac
to
a23df8e
Compare
sergio-costas
changed the title
audio-playback: add support for snapped pipewire
interfaces: add support for snapped pipewire
Sep 6, 2024
A snapped pipewire requires being able to create the pulse folder inside the global XDG_RUNTIME_DIR folder (not the snap own folder). Also, it requires to be able to create both the pipewire-[0-9]-manager and its lock file. This patch adds that capability to the audio-playback slot; thus, a snap offering that slot will be able to create the corresponding global sockets.
sergio-costas
force-pushed
the
add-support-for-snapped-pipewire
branch
from
September 12, 2024 13:56
ee549b3
to
263dbd8
Compare
@sergio-costas, this is not targetting 2.66 release anymore, let me know if you want to discuss |
Thanks @ernestl. This is still a work in progress, and there's no hurry. I just uploaded here as a draft to ensure that it doesn't end in "limbo", since all the testing and work is being done in our core desktop snapd branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A snapped pipewire requires to be able to create the pulse folder inside the global XDG_RUNTIME_DIR folder (not the snap own folder). Also, it requires to be able to create both the pipewire-[0-9]-manager and its lock file.
This patch adds that capability to the new pipewire interface, and also modifies the audio-playback interface; thus, a snap offering those slots will be able to create the corresponding global sockets, and a snap using them will be able to access the global ones.
This patch is required to snap pipewire, which is a must for Core Desktop: https://github.com/sergio-costas/pipewire-snap
Thanks for helping us make a better snapd!
Have you signed the license agreement and read the contribution guide?