Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support standard and kernel-modules #5100

Open
wants to merge 1 commit into
base: hotfix/8.4
Choose a base branch
from
Open

feat: support standard and kernel-modules #5100

wants to merge 1 commit into from
+5 −4

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented Oct 7, 2024

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox run -m lint?
  • Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

Adds support for standard and kernel-modules component types.

(CRAFT-3520)
Fixes #5089

lengau
lengau approved these changes Oct 8, 2024
View reviewed changes
snapcraft/models/project.py Show resolved Hide resolved
tests/unit/models/test_projects.py Show resolved Hide resolved
@mr-cal mr-cal force-pushed the work/CRAFT-3520/component-types branch from b97e356 to f699bae Compare October 8, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lengau lengau lengau approved these changes

@mattculler mattculler mattculler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mr-cal @lengau @mattculler