fix(remote): use launchpad credentials from legacy location #4762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mr-cal
force-pushed
the
work/launchpad-credentials
branch
3 times, most recently
from
9c6ab5a
to
d93de7a
Compare
If launchpad credentials do not exist in the new location ($XDG_DATA_HOME/snapcraft/launchpad-credentials) but exist in the legacy location ($XDG_DATA_HOME/snapcraft/provider/launchpad/credentials), then emit a deprecation warning and copy the credentials to the new location. Signed-off-by: Callahan Kovacs <[email protected]>
mr-cal
force-pushed
the
work/launchpad-credentials
branch
from
d93de7a
to
83b6792
Compare
|
I'm not going to do this because we've given notice in the changelogs and call for testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tox run -m lint?tox run -e test-py310? (supported versions:py39,py310,py311,py312)If launchpad credentials do not exist in the new location (
$XDG_DATA_HOME/snapcraft/launchpad-credentials) but exist in the legacy location ($XDG_DATA_HOME/snapcraft/provider/launchpad/credentials), then emit a deprecation warning and copy the credentials to the new location.