-
Notifications
You must be signed in to change notification settings - Fork 656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy paste improvements #3849
base: main
Are you sure you want to change the base?
Copy paste improvements #3849
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## gui-open-shell-start-vm #3849 +/- ##
========================================================
Coverage 88.94% 88.95%
========================================================
Files 256 256
Lines 14584 14584
========================================================
+ Hits 12972 12973 +1
+ Misses 1612 1611 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Tested and working on my machine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything functions as expected and the code looks good! But why not add these shortcuts to other platforms?
412a174
to
b940cde
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The base branch was changed.
This PR adds Ctrl+Insert and Shift+Insert as copy/paste shortcuts for the terminal on Windows, as well as adding a right-click context menu in the terminal that provides copy/paste functionality.
It also refactors some of the terminal code by extracting some nested widgets into separate variables, since the nesting level was getting too big.
MULTI-1679