[cli/mount] remove default target if not specified #3696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## default-mount-target-in-daemon #3696 +/- ##
==================================================================
- Coverage 88.92% 88.92% -0.01%
==================================================================
Files 254 254
Lines 14299 14297 -2
==================================================================
- Hits 12716 12714 -2
Misses 1583 1583 ☔ View full report in Codecov by Sentry. |
andrei-toterman
force-pushed
the
default-mount-target-in-daemon
branch
from
089a957
to
9da2922
Compare
andrei-toterman
force-pushed
the
remove-default-mount-target-from-cli
branch
from
2d646dd
to
545a7c8
Compare
andrei-toterman
force-pushed
the
default-mount-target-in-daemon
branch
from
9da2922
to
e056ee9
Compare
andrei-toterman
force-pushed
the
remove-default-mount-target-from-cli
branch
from
545a7c8
to
dd10753
Compare
andrei-toterman
force-pushed
the
default-mount-target-in-daemon
branch
from
e056ee9
to
57873ac
Compare
andrei-toterman
force-pushed
the
remove-default-mount-target-from-cli
branch
from
dd10753
to
dd3a060
Compare
andrei-toterman
force-pushed
the
default-mount-target-in-daemon
branch
from
57873ac
to
d830495
Compare
andrei-toterman
force-pushed
the
remove-default-mount-target-from-cli
branch
from
dd3a060
to
51761e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply removes the responsibility of the CLI to choose a mount target path if it is not given, since that will now be the responsibility of the daemon. Thus, the CLI can now pass an empty target path to the daemon.