Create a test scenario for mixed version clustering #720
+258
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addyess
commented
Oct 8, 2024
Comment on lines
-140
to
-142
| if not config.SNAP: | ||
| pytest.fail("Set TEST_SNAP to the path where the snap is") | ||
|
|
There was a problem hiding this comment.
moved to test_util.util
addyess
commented
Oct 8, 2024
Comment on lines
-146
to
-147
| snap_path = (tmp_path / "k8s.snap").as_posix() | ||
|
|
There was a problem hiding this comment.
this is gone because we can install from all kinds of things now...track, channel, revision, or file
addyess
force-pushed
the
KU-1800/test-cluster-with-mixed-versions
branch
2 times, most recently
from
75d5fd7
to
41fe426
Compare
addyess
force-pushed
the
KU-1800/test-cluster-with-mixed-versions
branch
from
41fe426
to
d8aa2bc
Compare
addyess
force-pushed
the
KU-1800/test-cluster-with-mixed-versions
branch
from
50b41c7
to
5b3b8b1
Compare
addyess
force-pushed
the
KU-1800/test-cluster-with-mixed-versions
branch
from
e8eaf59
to
a88f1ce
Compare
addyess
commented
Oct 8, 2024
| @@ -12,40 +12,45 @@ | |||
|
|
|||
| @pytest.mark.node_count(1) | |||
| @pytest.mark.no_setup() | |||
| @pytest.mark.xfail(reason="cilium failures are blocking this from working") | |||
There was a problem hiding this comment.
@bschimke95 I did not see this to be the case any longer. I've fixed this test again and it seems to pass??
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
node_countornode_configwhen you wish to configure the nodes differently (say with a different snap version)Details