Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rollout upgrade integration test #29

Merged
merged 32 commits into from
Sep 4, 2024
Merged

Conversation

bschimke95
Copy link
Contributor

@bschimke95 bschimke95 commented Jul 24, 2024

Summary

Adds a test that creates a HA workload cluster and upgrades it from 1.29 Kubernetes to 1.30.

Implementation details

  • Non-HA clusters require in-place updates which are currently not supported
  • We don't have snapd on the docker infra and cannot install different versions via snap install. That's why we build two different docker images and replace the infrastructure reference accordingly along with the upgrade. On other infra providers we would simply change the version and not the image.
  • Right now, we inject a Kubernetes override into the docker build process as we don't have another minor release besides 1.30. Once 1.31 is out, we can bump the test versions, upgrade from 1.30 -> 1.31 and remove this hack in the build process.

Notes

This tests require canonical/microcluster#197 to land in microcluster and canonical/k8s-snap#560 and canonical/k8s-snap#562 to land in k8s-snap.

Copy link

@addyess addyess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just comments. I don't feel like I can give better feedback

templates/aws/ccm.yaml Outdated Show resolved Hide resolved
templates/docker/Dockerfile Outdated Show resolved Hide resolved
templates/docker/Dockerfile Outdated Show resolved Hide resolved
test/e2e/helpers.go Outdated Show resolved Hide resolved
Copy link
Contributor

@neoaggelos neoaggelos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, left some comments around structure

.github/workflows/e2e.yaml Show resolved Hide resolved
.github/workflows/e2e.yaml Outdated Show resolved Hide resolved
test/e2e/config/ck8s-docker.yaml Show resolved Hide resolved
@bschimke95 bschimke95 force-pushed the KU-1052/rollout-test branch 2 times, most recently from 7b14410 to 35491a1 Compare August 28, 2024 11:00
Copy link
Contributor

@HomayoonAlimohammadi HomayoonAlimohammadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks a lot @bschimke95! Just some minor comments and questions.

@bschimke95
Copy link
Contributor Author

The upgrade test passes, the other tests are known to be faulty/flaky and will be fixed as follow-up work.

@bschimke95 bschimke95 merged commit 4fad9a7 into main Sep 4, 2024
3 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants