Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat UrlResolver #4546

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat UrlResolver #4546

wants to merge 1 commit into from

Conversation

xmgdtc
Copy link

@xmgdtc xmgdtc commented Aug 21, 2024

1 use UrlResolver class to replace baseUrl string in ExternalTaskClientBuilder.class so that we can control how to get the address such as use load balance

1 use UrlResolver to replace baseUrl in ExternalTaskClientBuilder.class so that we can use load balance address
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


mxl1909 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@danielkelemen
Copy link
Member

Hi @xmgdtc,

Thank you for opening a PR!
You need sign our CLA Contributor License Agreement in order to be able to contribute.

So this feature would make it possible to change the baseUrl dynamically without restarting the client. It makes sense, I will soon review your code changes and provide some feedback.

-Daniel

@xmgdtc
Copy link
Author

xmgdtc commented Aug 26, 2024

i have completed and signed this agreement thank you for your review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants