WIP FUSETOOLS2-1624 - Support automatic restart #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apupier
force-pushed
the
1624-supportAutomaticRedeploy
branch
from
443ea53
to
160b064
Compare
When Automatic restart of Camel route is configured, the JMX connection vanishes for few seconds. Adding code to be able to reconnect. As a first iteration ,allow 5 seconds for the connection to be up again. - how to test it? - How to check we have no potential zombies if reconnection last more than 5 seconds or if it was an abrupt stop? - if automatic reload is done in the one second time between two check of suspended nodes, we won't detect the reload. For now, I do not see a better way than to live with it as it shouldn't occur a lot, with a very simple use case, it is taking always more than a second on my relatively fast machine. Current proposal is working only with Quarkus with a not robust implementation and I cannot manage to write a test for this case. i tis not working with Camel JBangand I do not see how to detect that there was a reload. I'm wondering if the breakpoints are kept on route reload, it would not be enough to work on most cases. Maybe a better approach is to support the "restart" of the debug adapter which is available in VS Code UI when the code has been detected as modified. Signed-off-by: Aurélien Pupier <[email protected]>
apupier
force-pushed
the
1624-supportAutomaticRedeploy
branch
from
160b064
to
233a05c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Automatic restart of Camel route is configured, the JMX connection
vanishes for few seconds. Adding code to be able to reconnect. As a
first iteration ,allow 5 seconds for the connection to be up again.
than 5 seconds or if it was an abrupt stop?