fix: check for invalid configuration in limit settings #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
If lowerLimit > upperLimit we shouldn't fallback to upperLimit. If we do that, then we will end up with having lowerLimit === upperLimit, which will prevent Slider from moving at all. This is not the best experience.
If a dev/user makes a simple mistake, typo, of having lowerLimit greater than the upper one, then we should just avoid setting that incorrect limit. In that worst case, the limit that is incorrect will just not work, not the whole Slider.
package/android/src/main/java/com/reactnativecommunity/slider/ReactSlider.java
Outdated
Show resolved
Hide resolved
package/android/src/main/java/com/reactnativecommunity/slider/ReactSlider.java
Outdated
Show resolved
Hide resolved
BartoszKlonowski
approved these changes
Sep 24, 2024
package/android/src/main/java/com/reactnativecommunity/slider/ReactSlider.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
fixes: #571
Apply additional check and move the progress calculation to Slider class
Test Plan:
Have ran the application examples on new/old arch witch success - the crash is not happening anymore.