Consistent aliasing for assocs. #7776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://book.cakephp.org/5/en/orm/associations.html#hasone-associations
For beginners it can probably be confusing to see only hasOne() relations in singular, and only sometimes.
If anything, I would have expected belongsTo() to be singular, since there can always be only one ever.
HasOne() could easily become hasMany() by allowing more rows to be allowed, and then requires more massive refactoring.
So from the convention approach, it seems sound to stick here to the default, plural.
What do others think?