Derive Default for Color, TriColor and OctColor #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This matches BinaryColor in `embedded-graphics`, and is required by the `embedded-text` crate.
|
Hey, I ran into the same issue trying to used the embedded-text crate, hopefully this will be merged quickly 🙏🏾 |
|
Makes sense. Thanks for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches
BinaryColorinembedded-graphics.While I don't think anyone should particularly be relying on the output of
Color::default(), theembedded-textcrate has a trait bound ofC: PixelColor + Default, which it uses it when "resetting" a style - just to have something to temporarily set the text colour to, presumably with the assumption that if it's being reset, it's about to be set to something sensible again in a moment.https://github.com/embedded-graphics/embedded-text/blob/ea5271d32512eeed7a6caadf09509ff5d2447c63/src/rendering/line.rs#L24-L42
Given
BinaryColoralready has a similar behaviour, I figure this seems like a simple enough trait bound to simply satisfy like this. This patch is currently being successfully used in one of my own projects.