-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix settings and add config option for typos
hook
#333
Merged
domenkozar
merged 2 commits into
cachix:master
from
totoroot:add-config-option-typos-hook
Aug 3, 2023
Merged
Fix settings and add config option for typos
hook
#333
domenkozar
merged 2 commits into
cachix:master
from
totoroot:add-config-option-typos-hook
Aug 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
totoroot
pushed a commit
to totoroot/git-hooks.nix
that referenced
this pull request
Aug 4, 2023
Fix settings and add config option for `typos` hook
totoroot
pushed a commit
to totoroot/git-hooks.nix
that referenced
this pull request
Aug 4, 2023
Fix settings and add config option for `typos` hook
totoroot
pushed a commit
to totoroot/git-hooks.nix
that referenced
this pull request
Aug 4, 2023
Fix settings and add config option for `typos` hook
totoroot
pushed a commit
to totoroot/git-hooks.nix
that referenced
this pull request
Aug 4, 2023
Fix settings and add config option for `typos` hook
totoroot
pushed a commit
to totoroot/git-hooks.nix
that referenced
this pull request
Aug 4, 2023
Fix settings and add config option for `typos` hook
totoroot
pushed a commit
to totoroot/git-hooks.nix
that referenced
this pull request
Aug 4, 2023
Fix settings and add config option for `typos` hook
totoroot
pushed a commit
to totoroot/git-hooks.nix
that referenced
this pull request
Aug 4, 2023
Fix settings and add config option for `typos` hook
totoroot
pushed a commit
to totoroot/git-hooks.nix
that referenced
this pull request
Aug 4, 2023
Fix settings and add config option for `typos` hook
totoroot
pushed a commit
to totoroot/git-hooks.nix
that referenced
this pull request
Aug 4, 2023
Fix settings and add config option for `typos` hook
totoroot
pushed a commit
to totoroot/git-hooks.nix
that referenced
this pull request
Aug 4, 2023
Fix settings and add config option for `typos` hook
totoroot
pushed a commit
to totoroot/git-hooks.nix
that referenced
this pull request
Aug 4, 2023
Fix settings and add config option for `typos` hook
totoroot
pushed a commit
to totoroot/git-hooks.nix
that referenced
this pull request
Aug 4, 2023
Fix settings and add config option for `typos` hook
totoroot
pushed a commit
to totoroot/git-hooks.nix
that referenced
this pull request
Aug 4, 2023
Fix settings and add config option for `typos` hook
totoroot
pushed a commit
to totoroot/git-hooks.nix
that referenced
this pull request
Aug 4, 2023
Fix settings and add config option for `typos` hook
totoroot
pushed a commit
to totoroot/git-hooks.nix
that referenced
this pull request
Aug 4, 2023
Fix settings and add config option for `typos` hook
totoroot
pushed a commit
to totoroot/git-hooks.nix
that referenced
this pull request
Aug 4, 2023
Fix settings and add config option for `typos` hook
totoroot
pushed a commit
to totoroot/git-hooks.nix
that referenced
this pull request
Aug 4, 2023
Fix settings and add config option for `typos` hook
totoroot
pushed a commit
to totoroot/git-hooks.nix
that referenced
this pull request
Aug 4, 2023
Fix settings and add config option for `typos` hook
totoroot
pushed a commit
to totoroot/git-hooks.nix
that referenced
this pull request
Aug 4, 2023
Fix settings and add config option for `typos` hook
totoroot
pushed a commit
to totoroot/git-hooks.nix
that referenced
this pull request
Aug 4, 2023
Fix settings and add config option for `typos` hook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed what I broke earlier, when I introduced new options for the
typos
hook 😅I also added a
config
andconfigPath
option. With theconfig
option it becomes possilble to pass the configuration right from thedevenv
configuration. This should fix #291.This time I tested all the settings in a newly created project to make sure everything works as expected.
Additionally, I changed the wording for some settings to make the references more consistent.