Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remix nodejs+postgres example #948

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

frontsideair
Copy link

@frontsideair frontsideair commented Jan 23, 2024

I created a basic Remix example that uses PostgreSQL.

I couldn't find a simple enough full-stack Remix template so I created my own. It can be regularly rebased on top of the official default template, and I feel comfortable about transferring repo ownership to cachix organization.

The test seems to be passing on my machine, but I'm open to improvements. I based everything on Ruby on Rails example and my own experimental project where I started using devenv.

A Next.js example can be built based on this relatively easily if needed.

@frontsideair frontsideair changed the title Create remix nodejs+postgres example Remix nodejs+postgres example Jan 23, 2024
@frontsideair
Copy link
Author

frontsideair commented Jan 23, 2024

@domenkozar I cleaned the create-remix output a bit.

There are many failing tests, at least one is because of prisma dependency on libssl. I could simplify the template to use PostgreSQL with a simpler library, but this is a pretty typical Remix setup so it has testing and example value.

Especially since the docker compose setup I replaced had binary incompatibilities between native macOS I'm using and the docker linux environment caused by Prisma, which worked with devenv out of the box.

@domenkozar
Copy link
Member

Would be great to fix the tests so it can be merged.

@frontsideair
Copy link
Author

I would find some direction immensely helpful, as there are 71 tests failing and many of them are not related to this PR as far as I can tell. Would rebasing on main help? And the question about Prisma dependency on libssl remains, which solution would you recommend?

@domenkozar
Copy link
Member

Ideally we'd fix prisma in nixpkgs so that it works.

@frontsideair
Copy link
Author

I rebased my changes in case it helps. I'd be really happy to get this merged, I plan to write a blog post about using devenv to manage dependencies for a Node.js project and it'd be nice to have an official example in place for that.

@domenkozar
Copy link
Member

@frontsideair happy to merge once tests pass, can you make sure those work?

@frontsideair
Copy link
Author

I think I fixed them @domenkozar, running devenv shell devenv-test-example remix locally passes.

@frontsideair
Copy link
Author

Every test is failing for a separate reason, one failing because of libssl, one is getting 403 from GitHub, two because they can't find npm. I'm very much lost.

@domenkozar
Copy link
Member

I'm currently focusing effort to get #1005 out, once it's done I can help you take a look.

@domenkozar
Copy link
Member

@frontsideair hey, can you rebase and see where we're at?

@frontsideair
Copy link
Author

@domenkozar Rebased, thanks for keeping tabs on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants