Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inputsFrom option #861

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

BurNiinTRee
Copy link
Contributor

This mimics the mkShell argument with the same name. Adds all buildInputs, nativeBuildInputs, etc. to the installed packages.
Closes: #809

This mimics the mkShell argument with the same name.
Adds all buildInputs, nativeBuildInputs, etc.
to the installed packages
[ "stdenv" "defaultNativeBuildInputs" ]
]);
in
lib.mkAfter allInputs;
Copy link
Contributor Author

@BurNiinTRee BurNiinTRee Nov 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will most likely have a lot of duplicate packages when passed multiple packages, how is this handled?
Packages added like this should appear in search paths after any explicitly added packages.

@I-Want-ToBelieve
Copy link

I-Want-ToBelieve commented Nov 22, 2023

I ran into a problem when trying to install treefmt-nix with the instructions , this PR looks to fix it.

Add config.treefmt.build.wrapper to the nativeBuildInputs of your devShell. This will make the treefmt command available in the shell using the specified configuration.

https://github.com/srid/rust-nix-template/blob/50cf0bae8990b8d2f6038739880693cc0ab36cc0/flake.nix#L37

@domenkozar
Copy link
Member

We need a test for this.

@domenkozar domenkozar added the needs tests Needs tests label Feb 17, 2024
@domenkozar
Copy link
Member

I don't like the name, because inputs already refer to flake inputs.

Maybe shellFor?

@domenkozar
Copy link
Member

Could you rebase?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs tests Needs tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add inputsFrom option/function to Shells
3 participants