Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not following, what sets
$DEVENV_RUNTIME
when evaluating usingnix develop
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We first eval the shell and compute the initial
devenv.runtime
based on the either theXDG_RUNTIME_DIR
orTMPDIR
. This then becomes$DEVENV_RUNTIME
in the launched shell (set viaenv.DEVENV_RUNTIME
).In the shell,
nix develop
updates theTMPDIR
env, butdevenv.runtime
has no way of picking this up retroactively.Once inside the shell, we run
devenv up
, which re-evaluates theprocfileScript
and picks up the newTMPDIR
.devenv.runtime
is now different, but theenterShell
script that creates the runtime dir is not run again.This is a bit of a hack anyways. I think the right way to solve this is to eval everything once. Something like #1142 should fix this.