Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(rust)::> Github Workflow to verify new crates that are being introduced #8266

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

PsychoPunkSage
Copy link
Contributor

Closes #2526

Made a check_crate.yml workflow that will be triggered when push or pull request are made.
It will run simple script at each steps ti check for Change.log and readme.md

@PsychoPunkSage PsychoPunkSage requested a review from a team as a code owner July 7, 2024 15:17
@PsychoPunkSage PsychoPunkSage marked this pull request as draft July 7, 2024 15:17
@PsychoPunkSage
Copy link
Contributor Author

CONCEPT:
I fetch all the members from root Cargo.toml and use it in my further checks.
Check involves:

  1. Presence of CHANGELOG.md
  2. Presence of README.md
  3. Whether Cargo.toml follows allowed sets of categories

@PsychoPunkSage PsychoPunkSage marked this pull request as ready for review July 7, 2024 15:45
@PsychoPunkSage PsychoPunkSage changed the title chore::> Github Workflow to verify new crates that are being introduced ci(rust)::> Github Workflow to verify new crates that are being introduced Jul 15, 2024
Copy link
Member

@metaclips metaclips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome PR @PsychoPunkSage little changes left, and we should merge this PR, also you should make the commit message
ci: github workflow to verify new crates that are being introduced
We do not support uppercase in our commit messages, this JS file contains code rules for commits https://github.com/build-trust/ockam/blob/develop/tools/commitlint/commitlint.config.js

.github/workflows/check_crate.yml Outdated Show resolved Hide resolved
.github/workflows/check_crate.yml Outdated Show resolved Hide resolved
.github/workflows/check_crate.yml Outdated Show resolved Hide resolved
.github/workflows/check_crate.yml Outdated Show resolved Hide resolved
@PsychoPunkSage
Copy link
Contributor Author

@metaclips
made required changes...
Please have a look at it..

@PsychoPunkSage
Copy link
Contributor Author

Hi @metaclips
Did you find time to review this PR?

@metaclips metaclips force-pushed the issue-2526 branch 9 times, most recently from 6ab9e72 to 1ea9ee0 Compare August 1, 2024 16:09
Copy link
Member

@metaclips metaclips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @PsychoPunkSage this PR found errors in our crates.

@metaclips metaclips added this pull request to the merge queue Aug 2, 2024
Merged via the queue into build-trust:develop with commit 42a7c1b Aug 2, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a checklist of things to verify when new crates are introduced.
3 participants