Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop legacy peer dependencies #2214

Merged
merged 5 commits into from
Oct 3, 2024
Merged

Drop legacy peer dependencies #2214

merged 5 commits into from
Oct 3, 2024

Conversation

yousif-bugsnag
Copy link
Contributor

@yousif-bugsnag yousif-bugsnag commented Oct 3, 2024

Goal

Drop legacy peer dependencies

Design

No longer required after dropping package-lock files from sub-packages and updating dependencies.

Changeset

remove use of --legacy-peer-deps flag in all build files (except the electron ci step), and remove the .npmrc file from the repo.

Removed all unnecessary unit-test related files and dependencies from the angular test fixture as these were causing conflicts and are not required for our tests.

legacy-peer-deps is still required in a couple of places:

  • browser webpack3 test fixture - older version of webpack causes a conflict, so added a .npmrc with legacy-peer-deps=true to the test fixture directory
  • Electron e2e tests - for electron tests, the packages are published to (and installed from) verdaccio using a very high canary version, but lerna doesn't update peer dependencies of packages when publishing, resulting in a conflict.

Testing

full ci build

Copy link

github-actions bot commented Oct 3, 2024

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 45.76 kB 13.77 kB
After 45.76 kB 13.77 kB
± No change No change

code coverage diff

<temporarily disabled>

Generated by 🚫 dangerJS against 1648634

@yousif-bugsnag yousif-bugsnag merged commit 456777b into next Oct 3, 2024
129 checks passed
@yousif-bugsnag yousif-bugsnag deleted the legacy-peer-deps branch October 3, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants