Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(react-native): Update Gradle and AGP in preparation for dropping jcenter #1442

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

bengourley
Copy link
Contributor

Goal

jcenter will be going away. Initially I tried to remove our reliance on jcenter for fixtures and examples, but not all of React Native's dependencies are available on Maven Central yet.

This PR just includes the gradle updates required, but doesn't drop jcenter just yet.

Copy link
Contributor

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending CI - unfortunately we'll need to revisit this once all the RN dependencies are available on jcenter, so the same ticket can continue tracking this.

@github-actions
Copy link

github-actions bot commented Jun 16, 2021

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 41.14 kB 12.66 kB
After 41.14 kB 12.66 kB
± No change No change

code coverage diff

Coverage values did not change👌.

Total:

Lines Branches Functions Statements
0%(+0%) 0%(+0%) 0%(+0%) 0%(+0%)

Generated by 🚫 dangerJS against 734ceca

@bengourley bengourley force-pushed the bengourley/jcenter-removal branch 2 times, most recently from 6402f24 to ba2e87a Compare June 17, 2021 15:12
@Udbhav12
Copy link

@bengourley Is there any update on this PR ? When will this get merged ?

@mattdyoung
Copy link
Contributor

@Udbhav12 - we weren't originally able to progress this PR due to not all the dependencies being available, but we plan to pick it up again soon.

@Udbhav12
Copy link

Udbhav12 commented Jan 6, 2022

@mattdyoung Thanks for update, Do we have any timelines for this ?

As per my understanding JCenter will completely shut down on February 1, 2022

https://blog.gradle.org/jcenter-shutdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants