This repository has been archived by the owner on Jun 9, 2023. It is now read-only.
Fixes Issue #216: Encourage individual icon component usage by removing Icon/index.js #395
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As suggested in the issue, remove the Icon/index.js file to prevent engineers from importing and restructuring, also made the file structure such that -
Due to this, had to change the imports for the icons in many other files and
pathToIconComponents
inscripts/generateIconComponents.js
that's why the no. of files changed in this PR is huge, but it was a necessary change.Motivation and Context
Fixes the Issue #216
Screenshots (if appropriate):
Types of changes
Checklist:
@djfarrelly @gmzjuliana @tomredman @msanroman